feat: support for transforming runner #8854

Mark1626 · 2019-08-19T19:53:32Z

Summary

Allow jest-runner to be transformable.

Part of #8810

Test plan

Have added test case for the change

Mark1626 · 2019-08-19T19:58:58Z

@SimenB e2e for pnp seems to fail, can you explain how it works, I don't have much context on it

packages/jest-core/src/TestScheduler.ts

Mark1626 · 2019-08-29T17:28:30Z

After much tedious debugging the culprit seems to be pirates, it seems to mutate Module._extensions

[Object: null prototype] {
      '.js': [Function],
      '.json': [Function],
      '.node': [Function],
      '': [Function] } // <- This is added

pnp is trying to module.load on node_modules/istanbul-reports/lib/json the mutation caused in Module._extensions is making it load the directory instead of the index.js.

I'll try to dig into pirates and see if it's expected ~~or an issue~~

Mark1626 · 2019-08-29T17:31:26Z

Line that's the problem

https://github.com/facebook/jest/blob/95688ac9c81c19ca1bbda3aaad2a278c2a60461f/packages/jest-transform/src/ScriptTransformer.ts#L478

codecov-io · 2019-08-29T18:28:54Z

Codecov Report

Merging #8854 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8854      +/-   ##
==========================================
+ Coverage   64.73%   64.73%   +<.01%     
==========================================
  Files         277      277              
  Lines       11707    11708       +1     
  Branches     2874     2875       +1     
==========================================
+ Hits         7578     7579       +1     
  Misses       3512     3512              
  Partials      617      617

Impacted Files	Coverage Δ
packages/jest-core/src/TestScheduler.ts	`65.67% <100%> (+0.25%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2c92b...bb7d5e5. Read the comment docs.

packages/jest-transform/src/ScriptTransformer.ts

Mark1626 · 2020-11-15T04:38:03Z

Rebased it against the current master

Not sure what's the problem with CI, it's only failing for macOS, and surprisingly enough I ran it against master in my local and I got the same.


  System:
    OS: macOS 10.15.5
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 12.19.0
    Yarn: 2.3.3-git.20201112.db30c005
    npm: 6.14.8
  npmPackages:
    jest: workspace:* => 26.6.3

SimenB · 2020-11-15T13:56:14Z

@Mark1626 I've opened up #10828 to track the CI failure

SimenB · 2020-11-15T13:57:37Z

Also, could you rebase (or just merge in master) again? Conflicts with #8751

Mark1626 · 2020-11-15T14:00:02Z

I'll rebase it

in rebase

SimenB · 2020-11-15T14:32:56Z

e2e/transform/transform-runner/package.json

+  "dependencies": {
+    "@babel/preset-env": "^7.0.0",
+    "@babel/preset-typescript": "^7.0.0",
+    "jest-environment-node": "^26.6.2"


Suggested change

"jest-environment-node": "^26.6.2"

"jest-environment-node": "file:../../../packages/jest-environment-node"

does that work? to avoid hard-coding a version

do we even need these dependencies? I don't see yarn being run in here

I'll check, the changes were made before yarn berry came in, with the file: protocol I'll see if it works

It works with the file: protocol in my local, updating in both here and the jest-env PR

e2e/transform/transform-runner/runner.ts

Co-authored-by: Simen Bekkhus <[email protected]>

github-actions · 2021-05-11T00:07:14Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

facebook-github-bot added the cla signed label Aug 19, 2019

jeysal reviewed Aug 20, 2019

View reviewed changes

packages/jest-core/src/TestScheduler.ts Outdated Show resolved Hide resolved

Mark1626 commented Aug 25, 2019

View reviewed changes

packages/jest-core/src/TestScheduler.ts Show resolved Hide resolved

Mark1626 force-pushed the feature/transform-runner branch from 96b0aae to cc09d52 Compare August 29, 2019 18:12

Mark1626 commented Aug 29, 2019

View reviewed changes

packages/jest-transform/src/ScriptTransformer.ts Outdated Show resolved Hide resolved

This was referenced Aug 30, 2019

Refractor requireAndTranspileModule to use exts from moduleFileExtenstions #8895

Merged

Support transforming all modules which can be specified in config #8810

Open

Mark1626 force-pushed the feature/transform-runner branch from 6bb4a96 to 59ff30c Compare August 31, 2019 08:54

Mark1626 marked this pull request as ready for review August 31, 2019 09:32

Mark1626 force-pushed the feature/transform-runner branch from 1ac7900 to cb5b4a7 Compare September 13, 2019 08:19

Mark1626 force-pushed the feature/transform-runner branch from cb5b4a7 to 7c28c0f Compare October 27, 2019 15:47

SimenB added this to the Jest 26 milestone Apr 28, 2020

cpojer modified the milestones: Jest 26, High priority future May 2, 2020

SimenB modified the milestones: High priority future, Jest 27 Oct 23, 2020

SimenB mentioned this pull request Nov 14, 2020

Support default exports for runners #10826

Closed

Mark1626 force-pushed the feature/transform-runner branch from bb7d5e5 to a71ce84 Compare November 15, 2020 04:11

Mark1626 added 4 commits November 15, 2020 19:36

feat: Allow transforming jest-runner

803b706

Replace test result with util

dd0181d

Fix linting

9fd4432

Fix lint due to newline

8c6af1b

Mark1626 added 5 commits November 15, 2020 19:36

Add moduleFileExtensions in tests

9ba2a35

Remove support for node 6

bf97acc

Add CHANGELOG

b6e1d5c

chore: Move CHANGELOG entry and upgrade e2e dependency and missed items

df745d2

in rebase

chore: Review change

61dab1f

Mark1626 force-pushed the feature/transform-runner branch from a71ce84 to 61dab1f Compare November 15, 2020 14:15

SimenB reviewed Nov 15, 2020

View reviewed changes

e2e/transform/transform-runner/runner.ts Outdated Show resolved Hide resolved

Mark1626 and others added 2 commits November 15, 2020 20:09

chore: Review change add import @jest/types as type

f1dc0a4

Co-authored-by: Simen Bekkhus <[email protected]>

chore: Use file protocol to resolve dependency

f546268

SimenB changed the title ~~Support for transforming runner~~ feat: support for transforming runner Nov 15, 2020

SimenB merged commit ed90920 into jestjs:master Nov 15, 2020

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support for transforming runner #8854

feat: support for transforming runner #8854

Mark1626 commented Aug 19, 2019

Mark1626 commented Aug 19, 2019

Mark1626 commented Aug 29, 2019 •

edited

Loading

Mark1626 commented Aug 29, 2019

codecov-io commented Aug 29, 2019 •

edited

Loading

Mark1626 commented Nov 15, 2020 •

edited

Loading

SimenB commented Nov 15, 2020

SimenB commented Nov 15, 2020 •

edited

Loading

Mark1626 commented Nov 15, 2020

SimenB Nov 15, 2020 •

edited

Loading

Mark1626 Nov 15, 2020

Mark1626 Nov 15, 2020

github-actions bot commented May 11, 2021

	"jest-environment-node": "^26.6.2"
	"jest-environment-node": "file:../../../packages/jest-environment-node"

feat: support for transforming runner #8854

feat: support for transforming runner #8854

Conversation

Mark1626 commented Aug 19, 2019

Summary

Test plan

Mark1626 commented Aug 19, 2019

Mark1626 commented Aug 29, 2019 • edited Loading

Mark1626 commented Aug 29, 2019

codecov-io commented Aug 29, 2019 • edited Loading

Codecov Report

Mark1626 commented Nov 15, 2020 • edited Loading

SimenB commented Nov 15, 2020

SimenB commented Nov 15, 2020 • edited Loading

Mark1626 commented Nov 15, 2020

SimenB Nov 15, 2020 • edited Loading

Choose a reason for hiding this comment

Mark1626 Nov 15, 2020

Choose a reason for hiding this comment

Mark1626 Nov 15, 2020

Choose a reason for hiding this comment

github-actions bot commented May 11, 2021

Mark1626 commented Aug 29, 2019 •

edited

Loading

codecov-io commented Aug 29, 2019 •

edited

Loading

Mark1626 commented Nov 15, 2020 •

edited

Loading

SimenB commented Nov 15, 2020 •

edited

Loading

SimenB Nov 15, 2020 •

edited

Loading